VarInt decoding pseudocode #4316
Conversation
MikeBishop
added
editorial
MikeBishop
requested review from
janaiyengar and
martinthomson
as code owners
|
And yes, this handwaves over coercing the mask into the right size integer for the number of bytes you read. |
There was a problem hiding this comment.
Thanks, @MikeBishop -- I think this is a useful improvement.
Co-authored-by: Martin Thomson <mt@lowentropy.net>
When you do that, it's probably worth copying the "Code Components" language from -recovery. |
| v = v & 0x3f | ||
| repeat length-1 times: | ||
| v = (v << 8) + data.next_byte() | ||
| return v |
There was a problem hiding this comment.
v is also in network byte-order, no?
There was a problem hiding this comment.
Yes, but I'm not sure that's necessary to mention. We haven't changed it over the course of the algorithm.
There was a problem hiding this comment.
How could it not be in network byte order? Unless next_byte does something other than read the next byte.
There was a problem hiding this comment.
What I meant is that we might want to say that the value still needs to converted into host byte order before it can be used.
There was a problem hiding this comment.
Doesn't this do that? I mean, the operations here are numeric, so unless << means "divide by 2^n", we're good, right?
There was a problem hiding this comment.
Yeah -- there's nothing here that is endian-specific.
Fixes #4300, if we decide we need/want it.